fix test due to a renamed parameter

Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
awslabs · Feb 6, 2024 · 8cde488 · 8cde488
1 parent 50b19ab
commit 8cde488
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/modules/sagemaker/sagemaker-endpoint/tests/test_app.py b/modules/sagemaker/sagemaker-endpoint/tests/test_app.py
@@ -16,7 +16,6 @@ def stack_defaults():
     os.environ["SEEDFARMER_PARAMETER_SAGEMAKER_PROJECT_ID"] = "12345"
     os.environ["SEEDFARMER_PARAMETER_SAGEMAKER_PROJECT_NAME"] = "sagemaker-project"
     os.environ["SEEDFARMER_PARAMETER_MODEL_PACKAGE_ARN"] = "example-arn"
-    os.environ["SEEDFARMER_PARAMETER_MODEL_BUCKET_ARN"] = "arn:aws:s3:::test-bucket"
 
     # Unload the app import so that subsequent tests don't reuse
     if "app" in sys.modules:

diff --git a/modules/sagemaker/sagemaker-endpoint/tests/test_stack.py b/modules/sagemaker/sagemaker-endpoint/tests/test_stack.py
@@ -33,7 +33,7 @@ def test_synthesize_stack_model_package_input() -> None:
     sagemaker_project_name = "sagemaker-project"
     vpc_id = "vpc-12345"
     model_package_arn = "example-arn"
-    model_bucket_arn = "arn:aws:s3:::test-bucket"
+    model_artifacts_bucket_arn = "arn:aws:s3:::test-bucket"
 
     endpoint_stack = stack.DeployEndpointStack(
         scope=app,
@@ -46,7 +46,7 @@ def test_synthesize_stack_model_package_input() -> None:
         model_execution_role_arn=None,
         vpc_id=vpc_id,
         subnet_ids=[],
-        model_bucket_arn=model_bucket_arn,
+        model_artifacts_bucket_arn=model_artifacts_bucket_arn,
         ecr_repo_arn=None,
         env=cdk.Environment(
             account=os.environ["CDK_DEFAULT_ACCOUNT"],
@@ -77,7 +77,7 @@ def test_synthesize_stack_latest_approved_model_package(mock_s3_client, stack_de
     sagemaker_project_name = "sagemaker-project"
     vpc_id = "vpc-12345"
     model_package_group_name = "example-group"
-    model_bucket_arn = "arn:aws:s3:::test-bucket"
+    model_artifacts_bucket_arn = "arn:aws:s3:::test-bucket"
 
     sagemaker_client = botocore.session.get_session().create_client("sagemaker", region_name="us-east-1")
     mock_s3_client.return_value = sagemaker_client
@@ -112,7 +112,7 @@ def test_synthesize_stack_latest_approved_model_package(mock_s3_client, stack_de
             model_execution_role_arn=None,
             vpc_id=vpc_id,
             subnet_ids=[],
-            model_bucket_arn=model_bucket_arn,
+            model_artifacts_bucket_arn=model_artifacts_bucket_arn,
             ecr_repo_arn=None,
             env=cdk.Environment(
                 account=os.environ["CDK_DEFAULT_ACCOUNT"],