-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GitHub integration for service catalog deployment template (#238)
* GitHub integration for service catalog deployment template * GitHub integration using codeconnection with CodePipeline * Updated default aws secret manager secret name * Added placeholders for README updates * Removed ARN value from manifest file * Moved GitHub repo creation to separate construct * Updated CHANGELOG * Moved GitHub source credential creation into lambda * Applied fix.sh for formating fixes * Fixed formating validation issues * Added GitHub repository delete support on sagemake project deletion * Removed account owner name * Unit tests fixes * Optimising configuration and parameters * Removed unwanted response data * Fixed parameter name * Added enum for types of repositories and moved remo management to common construct * Applied formatting fixes and unit test update * Enabled codecommit as default with github repository integration * Added example github repo manifest file * Updated readme and changelog * Updated codebuild project variable and corrected unit test * Optimised codepipeline and codebuild source creation for codecommit and github repos * Updated README with prerequesites information and updated unit tests * Applied changes from scripts/fix.sh * Fixed static checks and linting errors * Updated return type for codebuild source * Updated code build source type to ISource
- Loading branch information
Showing
13 changed files
with
658 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
examples/manifests/sagemaker-templates-modules-codecommit.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
name: service-catalog | ||
path: modules/sagemaker/sagemaker-templates-service-catalog | ||
targetAccount: primary | ||
parameters: | ||
- name: repository-type | ||
value: CodeCommit | ||
- name: portfolio-access-role-arn | ||
valueFrom: | ||
moduleMetadata: | ||
group: sagemaker-studio | ||
name: studio | ||
key: LeadDataScientistRoleArn | ||
- name: dev-account-id | ||
valueFrom: | ||
envVariable: PRIMARY_ACCOUNT | ||
- name: dev-region | ||
valueFrom: | ||
envVariable: PRIMARY_REGION | ||
- name: dev-vpc-id | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: VpcId | ||
- name: dev-subnet-ids | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: PrivateSubnetIds | ||
- name: pre-prod-account-id | ||
valueFrom: | ||
envVariable: PRIMARY_ACCOUNT | ||
- name: pre-prod-region | ||
valueFrom: | ||
envVariable: PRIMARY_REGION | ||
- name: pre-prod-vpc-id | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: VpcId | ||
- name: pre-prod-subnet-ids | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: PrivateSubnetIds | ||
- name: prod-account-id | ||
valueFrom: | ||
envVariable: PRIMARY_ACCOUNT | ||
- name: prod-region | ||
valueFrom: | ||
envVariable: PRIMARY_REGION | ||
- name: prod-vpc-id | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: VpcId | ||
- name: prod-subnet-ids | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: PrivateSubnetIds | ||
- name: sagemaker-domain-id | ||
valueFrom: | ||
moduleMetadata: | ||
group: sagemaker-studio | ||
name: studio | ||
key: StudioDomainId | ||
- name: sagemaker-domain-arn | ||
valueFrom: | ||
moduleMetadata: | ||
group: sagemaker-studio | ||
name: studio | ||
key: StudioDomainArn |
84 changes: 84 additions & 0 deletions
84
examples/manifests/sagemaker-templates-modules-github.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
name: service-catalog | ||
path: modules/sagemaker/sagemaker-templates-service-catalog | ||
targetAccount: primary | ||
parameters: | ||
- name: repository-type | ||
value: GitHub | ||
- name: repository-owner | ||
value: <github_account_owner> | ||
- name: access-token-secret-name | ||
value: github_token | ||
- name: aws-codeconnection-arn | ||
value: <arn> | ||
- name: portfolio-access-role-arn | ||
valueFrom: | ||
moduleMetadata: | ||
group: sagemaker-studio | ||
name: studio | ||
key: LeadDataScientistRoleArn | ||
- name: dev-account-id | ||
valueFrom: | ||
envVariable: PRIMARY_ACCOUNT | ||
- name: dev-region | ||
valueFrom: | ||
envVariable: PRIMARY_REGION | ||
- name: dev-vpc-id | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: VpcId | ||
- name: dev-subnet-ids | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: PrivateSubnetIds | ||
- name: pre-prod-account-id | ||
valueFrom: | ||
envVariable: PRIMARY_ACCOUNT | ||
- name: pre-prod-region | ||
valueFrom: | ||
envVariable: PRIMARY_REGION | ||
- name: pre-prod-vpc-id | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: VpcId | ||
- name: pre-prod-subnet-ids | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: PrivateSubnetIds | ||
- name: prod-account-id | ||
valueFrom: | ||
envVariable: PRIMARY_ACCOUNT | ||
- name: prod-region | ||
valueFrom: | ||
envVariable: PRIMARY_REGION | ||
- name: prod-vpc-id | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: VpcId | ||
- name: prod-subnet-ids | ||
valueFrom: | ||
moduleMetadata: | ||
group: networking | ||
name: networking | ||
key: PrivateSubnetIds | ||
- name: sagemaker-domain-id | ||
valueFrom: | ||
moduleMetadata: | ||
group: sagemaker-studio | ||
name: studio | ||
key: StudioDomainId | ||
- name: sagemaker-domain-arn | ||
valueFrom: | ||
moduleMetadata: | ||
group: sagemaker-studio | ||
name: studio | ||
key: StudioDomainArn |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.