-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sagemaker-studio
module
#6
Conversation
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing CHANGELOG entry
@@ -1,5 +1,5 @@ | |||
name: studio | |||
path: git::https://github.com/awslabs/idf-modules.git//modules/ml/sagemaker-studio?ref=release/1.3.0&depth=1 | |||
path: modules/sagemaker/sagemaker-studio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ok for now, but after the first release, please change this to a gitpath on the version so that users don't have to clone the entire repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes, will lock all module versions after the release is cut
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.