Histogram #151
Open
Histogram #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lksfrnz
force-pushed
the
Histogram
branch
4 times, most recently
from
1291a25
to
fcf8325
Compare
giancarlokc
reviewed
Jul 29, 2024
src/main/java/software/amazon/cloudwatchlogs/emf/model/Histogram.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudwatchlogs/emf/model/Histogram.java
Outdated
Show resolved
Hide resolved
giancarlokc
approved these changes
Jul 31, 2024
markkuhn
suggested changes
Aug 2, 2024
src/main/java/software/amazon/cloudwatchlogs/emf/model/Histogram.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudwatchlogs/emf/model/Histogram.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudwatchlogs/emf/model/Histogram.java
Outdated
Show resolved
Hide resolved
| import software.amazon.cloudwatchlogs.emf.exception.InvalidMetricException; | ||
|
|
||
| /** Represents the Histogram of the EMF schema. */ | ||
| public class HistogramMetric extends Metric<Histogram> { |
There was a problem hiding this comment.
class Histogram has less visibility than the member that uses it
src/main/java/software/amazon/cloudwatchlogs/emf/model/HistogramMetric.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudwatchlogs/emf/model/HistogramMetric.java
Outdated
Show resolved
Hide resolved
|
Do these new classes need to be thread safe? |
lksfrnz
force-pushed
the
Histogram
branch
2 times, most recently
from
b81d13f
to
84a5808
Compare
johnjang
approved these changes
Aug 6, 2024
The builder classes need to be and have been updated to reflect that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Histograms as a metric aggregation option. Users can create their own histograms and submit them as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.