Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating EC/ECDH/ECDSA for new P-384 code with common point doubling function. #147

Merged
merged 7 commits into from
May 20, 2024

Conversation

apetcher-amazon
Copy link
Contributor

@apetcher-amazon apetcher-amazon commented May 8, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Ticket: P128758919
AWS-LC PR: aws/aws-lc#1567

@apetcher-amazon apetcher-amazon changed the title Updating EC/ECDH for new P-384 code with common point doubling function. Updating EC/ECDH/ECDSA for new P-384 code with common point doubling function. May 8, 2024
Copy link
Contributor

@pennyannn pennyannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some observation that is not related to this fix.

The definition for points_to_ec_method_st seems to be out of sync with definition at https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/ec/p384.c#L1121. I wonder if we should update it to match them.

@apetcher-amazon
Copy link
Contributor Author

LGTM. Some observation that is not related to this fix.

The definition for points_to_ec_method_st seems to be out of sync with definition at https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/ec/p384.c#L1121. I wonder if we should update it to match them.

Good catch. The differences aren't a problem in the current state of formal verification (e.g. the function pointers aren't used by verified functions, or the pointed-to functions are assumed to be correct, anyway). But this is a good opportunity to correct this difference, so I made the changes in this PR.

@pennyannn pennyannn merged commit 0ff601e into awslabs:master May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants