Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate from rusoto to aws-sdk-rust #126

Merged
merged 21 commits into from
May 21, 2024
Merged

feat: migrate from rusoto to aws-sdk-rust #126

merged 21 commits into from
May 21, 2024

Conversation

ryota-sakamoto
Copy link
Contributor

@ryota-sakamoto ryota-sakamoto commented May 13, 2023 •
edited
Loading

Issue #, if available:

close #51

Description of changes:

rusoto is in maintenance mode so we need to migrate from rusoto to aws-sdk-rust. We will address some actions after the PR is merged.

  1. improve error message from dynein

We can show error message to use into_service_error but we need to consider what the informations are shown.

            error!("{}", e.into_service_error().meta());
  1. separate config implementation from app.rs

@ryota-sakamoto ryota-sakamoto changed the title feat: migrate rusoto from to aws-sdk-rust feat: migrate from rusoto to aws-sdk-rust May 13, 2023
@ryota-sakamoto ryota-sakamoto force-pushed the migrate-sdk branch 5 times, most recently from 73acfe6 to ebe17c2 Compare May 15, 2023 14:58
@ryota-sakamoto ryota-sakamoto force-pushed the migrate-sdk branch 4 times, most recently from 0827fcd to b0fad59 Compare June 21, 2023 13:17
@StoneDot StoneDot added the maintenance Need work to follow eco-system changes label Mar 1, 2024
@StoneDot
Copy link
Contributor

This task is blocked by #143.

@ryota-sakamoto ryota-sakamoto force-pushed the migrate-sdk branch 6 times, most recently from faff36b to d17749e Compare May 20, 2024 09:44
@ryota-sakamoto
chore: add aws-sdk-rust for dependencies
80511bb 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
refactor: use sdk in list_tables_api
f71ebaf 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
refactor: use sdk in list_tables_all_regions
9636019 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
refactor: use sdk in delete_table
4570dc4 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
refactor: use sdk in list_backups_api
23d391d 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
chore: remove rusoto_ec2 from dependencies
88ab101 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
refactor: use sdk in backup
b5737fa 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
refactor: move key from app.rs to key.rs
c2e3a8f 
Key is used by some functions so it should be divided from app.rs

Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
refactor: move utility functions from control.rs to util.rs
ba99b53 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
feat: remove rusoto_dynamodb
543c935 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
chore: remove rusoto_signature
1d4ba74 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
test: fix test
1d4e3bf 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
chore: remove cargo audit ignore
6b79381 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
chore: remove rusoto doc link
f486f57 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
fix: fix setup_container on local
8906d95 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto ryota-sakamoto marked this pull request as ready for review May 20, 2024 14:32
@ryota-sakamoto ryota-sakamoto requested review from a team as code owners May 20, 2024 14:32
StoneDot
StoneDot reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reviewing it. I left first quick comments.

src/app.rs Outdated Show resolved Hide resolved
tests/util/mod.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@ryota-sakamoto
chore: remove aws-types dependency
caa20a2 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
fix: get default region from RegionProviderChain
704cb0c 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
fix: overwrite endpoint_url when region is local
91ef6db 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
StoneDot
StoneDot reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second iteration of the review.

src/util.rs Outdated Show resolved Hide resolved
src/parser.rs Show resolved Hide resolved
src/app.rs Outdated Show resolved Hide resolved
src/bootstrap.rs Outdated Show resolved Hide resolved
src/bootstrap.rs Outdated Show resolved Hide resolved
src/bootstrap.rs Outdated Show resolved Hide resolved
src/bootstrap.rs Outdated Show resolved Hide resolved
src/bootstrap.rs Outdated Show resolved Hide resolved
src/control.rs Outdated Show resolved Hide resolved
tests/util/mod.rs Outdated Show resolved Hide resolved
@ryota-sakamoto
fix: fix review points
4cfcd3f 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
feat: use RetryConfig to define retry behavior
d10edfd 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@KIrie-0217 KIrie-0217 mentioned this pull request May 20, 2024
Closed
StoneDot
StoneDot reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finalized my review. Could you please review the comments I left? Thank you for your hard work on this pull request.

src/app.rs Outdated Show resolved Hide resolved
src/app.rs Outdated Show resolved Hide resolved
src/app.rs Outdated Show resolved Hide resolved
src/app.rs Outdated Show resolved Hide resolved
src/app.rs Outdated Show resolved Hide resolved
src/ddb/mod.rs Outdated Show resolved Hide resolved
src/key.rs Outdated Show resolved Hide resolved
@ryota-sakamoto
fix: fix review points
74e68bd 
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
@ryota-sakamoto
Copy link
Contributor Author

@StoneDot

Thank you for review. I have addressed all of the points you mentioned.

StoneDot
StoneDot approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this. I appreciate your contribution.

@ryota-sakamoto ryota-sakamoto merged commit 9c275f1 into main May 21, 2024
5 checks passed
@ryota-sakamoto ryota-sakamoto deleted the migrate-sdk branch May 21, 2024 02:05
@ryota-sakamoto ryota-sakamoto mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StoneDot StoneDot StoneDot approved these changes

Assignees
No one assigned
Labels
maintenance Need work to follow eco-system changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from rusoto to AWS SDK for Rust
2 participants
@ryota-sakamoto @StoneDot