Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show the number of processed items in import/export #141

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

StoneDot
Copy link
Contributor

Issue #, if available:
Partial implementation for #91.

Description of changes:
This pull request aims to partially resolve #91 by providing the current number of completed items. The calculation for item size requires additional work and depends on the SDK, which is currently undergoing changes. Therefore, I implemented this without the information on sizes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@StoneDot StoneDot force-pushed the export-progress branch 2 times, most recently from b49e5ba to bc06895 Compare July 8, 2023 17:41
@StoneDot StoneDot requested a review from kzym-w July 27, 2023 09:23
Copy link
Contributor

@kzym-w kzym-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested on my env and I found that it worked correctly.

Copy link
Contributor

@kzym-w kzym-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzym-w kzym-w merged commit bd470cf into awslabs:main Aug 10, 2023
1 check passed
@andres-lowrie
Copy link

sweet

@StoneDot StoneDot deleted the export-progress branch October 17, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Suggestion: Add a way to show progress of export
3 participants