-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag for developing dy admin apply
#156
Conversation
Thank you for trying to build new feature for dynein. As my quick search, I found that |
Do not display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check my comments? I think you need to sort out what you want to check on your test code. I'm terrible sorry, but I was not able to get your intention from the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check a new comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. LGTM
*Issue #155 (comment)
Description of changes:
During development, to eliminate the impact on users, ensure that apply only works when
--dev
is added.Now,
dy admin apply --dev
causes panic.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.