-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exponential backoff retry for ProvisionedThroughputExceeded / ThrottlingException / InternalServerError #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the delayed response.
First, thank you for bringing the excellent improvement to dynein. As you mentioned in the issue, exponential backoff enhances stability for batch writing. I am willing to merge this pull request. However, I would like to request some modifications because we need to maintain compatibility after the migration to AWS SDK for Rust, which is currently in progress.
I have left some comments requesting modifications. Could you please review these comments?
@StoneDot We have corrected the problem and would appreciate it if you could check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my comments. I appreciate your effort.
To merge this PR, we need a minor modification to pass the test and a change to maintain compatibility with Backon and AWS SDK. Also, please remember to squash these changes into a single commit after the review. It helps us track the change quickly.
The change of test code is required because we changed the structure of the configuration file. See the test code.
I believe it is pretty close to merging this.
I'm sorry for forgetting to mention this. You need to include the following message in the summary of the pull request.
|
@yoshidan Hello. I eagerly await your return so I can merge the pull request. I'm looking forward to moving forward with this. If you have any technical issues, please don't hesitate to let me know. I will assist you in completing the review process and merging this pull request. -- |
Signed-off-by: yoshidan <naohiro.y@gmail.com>
@StoneDot Sorry for the late response. Now I fixed the code. Please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your quick response and fix. I know everyone has many things to do and is busy, so please do not mind it.
All things seem excellent to me. Thank you for contributing it. I will approve this and merge it.
Signed-off-by: yoshidan <naohiro.y@gmail.com>
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
add exponential backoff retry for ProvisionedThroughputExceeded / ThrottlingException / InternalServerError
Issue #, if available:
#195
Description of changes:
Added the configuration to retry
batch_write_item_api
.Configuration
Since
retry_batch_write_item
is optional, it can be undefined.In this case, no retry is performed.
dy config dump
Execution Logs
Output retry logs with warn level.
ProvisionedThroughputExceeded
ThrottlingException