-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up #35
Clean up #35
Conversation
@@ -162,7 +162,8 @@ impl Plugin for OpenXrPlugin { | |||
let mut manual_texture_views = app.world.resource_mut::<ManualTextureViews>(); | |||
manual_texture_views.insert(LEFT_XR_TEXTURE_HANDLE, left); | |||
manual_texture_views.insert(RIGHT_XR_TEXTURE_HANDLE, right); | |||
drop(manual_texture_views); | |||
//drop non drop | |||
//drop(manual_texture_views); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was a change I wasn't sure of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea this seems fine to just remove. Probably leftover from an older bevy version where this was Drop
@@ -31,7 +31,7 @@ pub const RIGHT_XR_TEXTURE_HANDLE: ManualTextureViewHandle = ManualTextureViewHa | |||
/// Adds OpenXR support to an App | |||
#[derive(Default)] | |||
pub struct OpenXrPlugin; | |||
|
|||
#[allow(clippy::type_complexity)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be simplified, but lacked the expertise to be sure
This PR needs a rebase |
@@ -162,7 +162,8 @@ impl Plugin for OpenXrPlugin { | |||
let mut manual_texture_views = app.world.resource_mut::<ManualTextureViews>(); | |||
manual_texture_views.insert(LEFT_XR_TEXTURE_HANDLE, left); | |||
manual_texture_views.insert(RIGHT_XR_TEXTURE_HANDLE, right); | |||
drop(manual_texture_views); | |||
//drop non drop | |||
//drop(manual_texture_views); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea this seems fine to just remove. Probably leftover from an older bevy version where this was Drop
@@ -12,6 +12,7 @@ use crate::resources::{ | |||
|
|||
use openxr as xr; | |||
|
|||
#[allow(clippy::type_complexity)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could add this to cargo.toml (latest Rust version has a section for it):
[lints.clippy]
type_complexity = "allow"
too_many_arguments = "allow"
Stale |
lots of clean up to enabled cargo fmt, cargo clippy, and cargo rustdoc