-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up #35
Clean up #35
Changes from 7 commits
f5bcfb9
985c240
566ee83
cc74ea0
fb1c044
8823845
e50cde3
2c142b3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,7 @@ pub const RIGHT_XR_TEXTURE_HANDLE: ManualTextureViewHandle = ManualTextureViewHa | |
/// Adds OpenXR support to an App | ||
#[derive(Default)] | ||
pub struct OpenXrPlugin; | ||
|
||
#[allow(clippy::type_complexity)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this could be simplified, but lacked the expertise to be sure |
||
#[derive(Resource)] | ||
pub struct FutureXrResources( | ||
pub Arc< | ||
|
@@ -162,7 +162,8 @@ impl Plugin for OpenXrPlugin { | |
let mut manual_texture_views = app.world.resource_mut::<ManualTextureViews>(); | ||
manual_texture_views.insert(LEFT_XR_TEXTURE_HANDLE, left); | ||
manual_texture_views.insert(RIGHT_XR_TEXTURE_HANDLE, right); | ||
drop(manual_texture_views); | ||
//drop non drop | ||
//drop(manual_texture_views); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this was a change I wasn't sure of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yea this seems fine to just remove. Probably leftover from an older bevy version where this was |
||
let render_app = app.sub_app_mut(RenderApp); | ||
|
||
render_app | ||
|
@@ -219,6 +220,7 @@ impl PluginGroup for DefaultXrPlugins { | |
} | ||
} | ||
|
||
#[allow(clippy::too_many_arguments)] | ||
pub fn xr_begin_frame( | ||
instance: Res<XrInstance>, | ||
session: Res<XrSession>, | ||
|
@@ -334,7 +336,7 @@ pub fn end_frame( | |
let _span = info_span!("xr_end_frame").entered(); | ||
let result = swapchain.end( | ||
xr_frame_state.lock().unwrap().predicted_display_time, | ||
&*views.lock().unwrap(), | ||
&views.lock().unwrap(), | ||
&input.stage, | ||
**resolution, | ||
**environment_blend_mode, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could add this to cargo.toml (latest Rust version has a section for it):