-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial D3D12 implementation + improvements #50
Conversation
dea5ee4
to
82a4a25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partly went through a review, didn't have time to finish.
Thank you for taking a look, @TheButlah! I have a guest this weekend so I will make the changes when I find the time. Most of the comments were good points but relate to things I copied from the other driver, so I'll apply those changes as separate commits that make the same change on both sides. |
02ce026
to
888d908
Compare
Force push was rebasing and and squashing a little |
888d908
to
63fc9b6
Compare
Squashed in removing some unused imports |
63fc9b6
to
163e4a7
Compare
Set as draft to reflect an outstanding issue: got errors on Vulkan on Oculus PC because it doesn't select |
I suggest that approach, to prevent this PR from getting stale. I would open a subsequent PR to fix that particular issue after this is merged. |
081e049
to
396560e
Compare
80c1e66
to
cd1020e
Compare
This does require dxil.dll and dxcompiler.dll to be available, falling back to fxc if these cannot be found. Can be overridden by setting the WGPU_DX12_COMPILER environment variable to "fxc".
cd1020e
to
59ce1f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.