Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use AxelarGMPExecutable in Governance #184

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

ahramy
Copy link
Contributor

@ahramy ahramy commented Sep 4, 2024

AXE-4750

  • Use the new executable for AxelarServiceGovernance in axelar-gmp-sdk-solidity
  • Bump the package.json version to 5.11.0

Unit Test All Passed:

EVM_VERSION="london" npm run test;
  359 passing (7s)

@ahramy ahramy requested a review from a team as a code owner September 4, 2024 18:51
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (849152c) to head (4b58997).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   98.68%   98.54%   -0.14%     
==========================================
  Files          48       48              
  Lines         759      758       -1     
  Branches      157      157              
==========================================
- Hits          749      747       -2     
  Misses          1        1              
- Partials        9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/governance/InterchainGovernance.js Outdated Show resolved Hide resolved
contracts/governance/InterchainGovernance.sol Show resolved Hide resolved
@ahramy ahramy merged commit b53530c into main Sep 4, 2024
5 checks passed
@ahramy ahramy deleted the feat/use_gmp_executable_in_governance branch September 4, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants