Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use named return #189

Merged
merged 8 commits into from
Sep 25, 2024
Merged

chore: use named return #189

merged 8 commits into from
Sep 25, 2024

Conversation

ahramy
Copy link
Contributor

@ahramy ahramy commented Sep 24, 2024

AXE-5205

  • Use the named return variables for efficient gas and consistency.
  • Updated comments accordingly.

@ahramy ahramy requested a review from a team as a code owner September 24, 2024 22:39
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (115300a) to head (9d7edd8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files          48       48              
  Lines         758      756       -2     
  Branches      157      157              
==========================================
- Hits          757      755       -2     
  Misses          1        1              
Flag Coverage Δ
99.86% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahramy ahramy changed the title Chore/use named return Chore: use named return Sep 24, 2024
@ahramy ahramy changed the title Chore: use named return chore: use named return Sep 24, 2024
contracts/gateway/AxelarAmplifierGateway.sol Outdated Show resolved Hide resolved
contracts/gateway/BaseAmplifierGateway.sol Outdated Show resolved Hide resolved
contracts/governance/BaseMultisig.sol Outdated Show resolved Hide resolved
@ahramy ahramy merged commit 7c9f527 into main Sep 25, 2024
5 checks passed
@ahramy ahramy deleted the chore/use_named_return branch September 25, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants