tests: avoid modifying PATH outside CI #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo test` outside CI would end up adding the temporary directory persistently to user's real dotfiles. Leave this on in CI because it doesn't hurt anything there. NOTE: this environment variable isn't supported on Windows at the moment - we should probably try to unify that behaviour. Refs axodotdev/cargo-dist#1374.
Gankra
approved these changes
Aug 28, 2024
|
We use |
mistydemeo
added a commit
to axodotdev/cargo-dist
that referenced
this pull request
Aug 28, 2024
This is supported from the environment in the shell installer, but was previously only supported on the CLI in the powershell installer. This will be useful to ensure axoupdater tests don't pollute the environment: axodotdev/axoupdater#168 refs #1374.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo testoutside CI would end up adding the temporary directory persistently to user's real dotfiles. Leave this on in CI because it doesn't hurt anything there.NOTE: this environment variable isn't supported on Windows at the moment - we should probably try to unify that behaviour.
Refs axodotdev/cargo-dist#1374.