feat: use self_replace to delete self #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
self_replace
branch
2 times, most recently
from
8b83f83
to
bb0154f
Compare
|
@mitsuhiko - I've given |
Gankra
approved these changes
Sep 19, 2024
|
|
||
| Some((ourselves, old_path)) | ||
| let mut new_filename = old_filename.as_os_str().to_os_string(); | ||
| new_filename.push(OsStr::new(".__selfdelete__.exe")); |
There was a problem hiding this comment.
Yes, it's mentioned here in the docs: https://docs.rs/self-replace/1.5.0/self_replace/#implementation I'll add a comment.
mistydemeo
force-pushed
the
self_replace
branch
from
bb0154f
to
4eedd8c
Compare
|
You can give it that suffix but it really should not matter. It will move it over to the right name anyways. I did not check too much but if you are doing something somewhat dodgy that the crate does not directly support, I'm happy to add a better API :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at handling axodotdev/cargo-dist#1374 using the self-replace crate. We leave the existing Unix behaviour in place, since it's already safe, but it replaces the previous Windows version with a new one: the Windows EXE is given a specific temporary name and, if the upgrade succeeded, we then set a flag to ensure it's deleted once the process completes.
Appears to be working on Windows but needs more testing.