Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: powershell respects NoModifyPath from env #1379

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mistydemeo
Copy link
Contributor

This is supported from the environment in the shell installer, but was previously only supported on the CLI in the powershell installer.

This will be useful to ensure axoupdater tests don't pollute the environment: axodotdev/axoupdater#168

refs #1374.

This is supported from the environment in the shell installer, but
was previously only supported on the CLI in the powershell installer.

This will be useful to ensure axoupdater tests don't pollute the
environment: axodotdev/axoupdater#168

refs #1374.
@mistydemeo mistydemeo requested a review from Gankra August 28, 2024 17:19
Copy link
Contributor

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is -not the right operator here still..?

@mistydemeo
Copy link
Contributor Author

I think so? Empty string is also falsy. Does the CLI parsing here convert to true/false?

PS /Users/mistydemeo> -not $null
True
PS /Users/mistydemeo> -not ""
True
PS /Users/mistydemeo> -not "0"
False
PS /Users/mistydemeo> -not "1"
False

@mistydemeo mistydemeo merged commit c77b0c1 into main Aug 28, 2024
16 checks passed
@mistydemeo mistydemeo deleted the powershell_respect_env_no_modify_path branch August 28, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants