Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: load oranda.toml as well #629

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: load oranda.toml as well #629

wants to merge 1 commit into from

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Sep 5, 2023

Notes:

  • is currently hacky because of the way oranda selects oranda.json
    • if the config path doesn't exist, but it ends with .json, tries .toml as well
    • because at that point in the code we can't distinguish user-provided path and the default path
  • analytics needs to be written in a kind of messed up way because of Deserialize enum table? toml-rs/toml-rs#390
  • this PR replaces oranda.json with oranda.toml just to show it off, but that breaks web.yml and obviously shouldn't be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant