Package specific releases #652
Conversation
|
Not sure why it's showing that entire file as changed atm, will review. Edit: After adding the changes to Edit 2: Not really sure why that was happening but I redid the changes and now its happy without needing to change the entire file, so yay! |
06chaynes
force-pushed
the
package-specific-releases
branch
from
164aeec
to
2c2a9ae
Compare
| @@ -38,6 +38,7 @@ enum ArtifactSystem { | |||
| pub struct ArtifactsConfig { | |||
| pub auto: bool, | |||
| pub cargo_dist: bool, | |||
| pub package_specific_releases: bool, | |||
There was a problem hiding this comment.
While this is a good addition, I would change the name, maybe to match_package_names (seems more immediately obvious to me what it does that way). Also adding it to the docs reference page would be nice, but no worries, I can also do that.
There was a problem hiding this comment.
I wasn't sure about the naming either, I'll get those updates made a bit later today. Thanks for the quick response!
There was a problem hiding this comment.
Just pushed these changes, also added a doc entry but feel free to tweaks as needed!
There was a problem hiding this comment.
actually ill fix that clippy
This adds a new optional field to the artifacts config
package_specific_releaseswhich will default to false. When false things will work as they currently do, when true an additional check is enabled inContext::with_releasesthat will skip the release should the version tag not contain the project name.This also modifies
Context::with_releasesto require a reference to ProjectConfig as an argument in order to perform the check against the project name.