feat: use extra artifacts instead of append release #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
requested changes
Nov 29, 2023
Comment on lines
-66
to
-87
| oranda-css: | ||
| name: Add oranda-css to release | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| runs-on: ubuntu-latest | ||
| needs: ["should-run"] | ||
| if: ${{ needs.should-run.outputs.val == 'run' }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| ref: ${{ github.event.workflow_run.head_branch }} | ||
| fetch-depth: 0 | ||
| - name: Install oranda and build CSS | ||
| run: | | ||
| echo "uploading CSS to ${{ github.event.workflow_run.head_branch }}" | ||
| curl --proto '=https' --tlsv1.2 -LsSf https://github.com/axodotdev/oranda/releases/download/${{ github.event.workflow_run.head_branch }}/oranda-installer.sh | sh | ||
| oranda generate-css | ||
| ls oranda-css/dist | ||
| echo "built css!" | ||
| # Upload css to the Github Release™ | ||
| gh release upload ${{ github.event.workflow_run.head_branch }} oranda-css/dist/oranda.css | ||
| echo "uploaded css!" |
There was a problem hiding this comment.
it doesn't look like you added generation for oranda-css, and this is the Really Important one to migrate.
There was a problem hiding this comment.
I actually totally missed that one - I'll add it now.
mistydemeo
force-pushed
the
add_extra_artifacts
branch
2 times, most recently
from
d26d379
to
b6ea79f
Compare
Gankra
force-pushed
the
add_extra_artifacts
branch
from
b6ea79f
to
b75d40a
Compare
Gankra
approved these changes
Feb 23, 2024
Gankra
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of cargo-dist includes a new feature that allows building and uploading extra artifacts as a part of the main build, without any
AppendReleasetrickery: axodotdev/cargo-dist#613 To make the config a bit easier, I added a flag toconfig-schemato allow writing it to a file without piping.This can't be merged until that new release of cargo-dist is out and we're updated to use it, however.