Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Bump okp4d version #386

Merged
merged 2 commits into from
Oct 4, 2023
Merged

🔨 Bump okp4d version #386

merged 2 commits into from
Oct 4, 2023

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented Oct 3, 2023 •
edited
Loading

See #385 for more details, and see #385 (comment) for temporary fix explanation :).

@bot-anik
Copy link
Member

bot-anik commented Oct 3, 2023 •
edited
Loading

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/okp4_objectarium.wasm 425.7 KB (0%)
target/wasm32-unknown-unknown/release/okp4_law_stone.wasm 634.32 KB (0%)
target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm 791.91 KB (0%)

@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #386 (ca8f9d4) into main (a33fd65) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #386   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          42       42           
  Lines       10081    10081           
=======================================
  Hits         9891     9891           
  Misses        190      190

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdeneux bdeneux linked an issue Oct 3, 2023 that may be closed by this pull request
🔨 Bump okp4d version in local chain setup #385
Closed
@bdeneux bdeneux changed the title Build/bump okp4d 🔨 Bump okp4d version Oct 3, 2023
@bdeneux bdeneux self-assigned this Oct 3, 2023
ErikssonJoakim
ErikssonJoakim approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@ErikssonJoakim ErikssonJoakim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

ccamel
ccamel approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's do this. 😌

Good choice of emoji, btw.

amimart
amimart approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect let's do that! 😉

@bdeneux bdeneux merged commit 3380d7a into main Oct 4, 2023
18 checks passed
@bdeneux bdeneux deleted the build/bump-okp4d branch October 4, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccamel ccamel ccamel approved these changes

@amimart amimart amimart approved these changes

@ErikssonJoakim ErikssonJoakim ErikssonJoakim approved these changes

Assignees

@bdeneux bdeneux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨 Bump okp4d version in local chain setup
5 participants
@bdeneux @bot-anik @ccamel @amimart @ErikssonJoakim