Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie chart generator added #3090

Closed
wants to merge 11 commits into from
Closed

Conversation

pinakviramgama
Copy link
Contributor

πŸ› οΈ Fixes Issue

Fixes: #3053

πŸ‘¨β€πŸ’» Description

What does this PR do?

Added new feature named pie chart generator which generates pie chart on basis of input from user of their savings, investments and expenses.

here's the output of it.

Home.-.FinVeda.-.Personal.-.Microsoft_.Edge.2024-11-09.11-25-41.1.1.mp4

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
fin-veda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 9, 2024 5:21pm

Copy link

github-actions bot commented Nov 9, 2024

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 9, 2024

βœ… Deploy Preview for getfinveda ready!

Name Link
πŸ”¨ Latest commit 11369b3
πŸ” Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/672f99f3d5c12c000828e0b0
😎 Deploy Preview https://deploy-preview-3090--getfinveda.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 41
Accessibility: 60
Best Practices: 75
SEO: 73
PWA: 50
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@deepeshmlgupta
Copy link
Collaborator

deepeshmlgupta commented Nov 9, 2024

@pinakviramgama
can you explain me what are you changing in Testimonials.html, new.html, demo.html, addBlog.html, blog.html
as I think you have also not added this pie chart in the nab bar of other pages also

@pinakviramgama
Copy link
Contributor Author

Dear Sir, @deepeshmlgupta i have not made changes in other files, just made changes in index.html and created piechart file,

as i am working on another issue of testimonials.html as that file is not opening and only buffering so it might shown that there are changes.

@deepeshmlgupta
Copy link
Collaborator

So, its better to check you commit before pushing it in your PR so that it should be clear.
As you are working on other issues them add these files there and but in this pr only add the file that are related to this pr only

@pinakviramgama
Copy link
Contributor Author

Sorry sir @deepeshmlgupta for that mistake, i will try not to repeat that,

sir, i have updated the commit, please merge this PR.

@pinakviramgama
Copy link
Contributor Author

Sir @deepeshmlgupta , please merge this PR

@pinakviramgama
Copy link
Contributor Author

Dear @Sampadatiwari , please merge this PR

@pinakviramgama
Copy link
Contributor Author

Dear @Sampadatiwari , please merge this PR

@pinakviramgama
Copy link
Contributor Author

Dear @deepeshmlgupta , please merge this PR

@deepeshmlgupta
Copy link
Collaborator

@pinakviramgama firstly you have to remove the unnecessary files that are not need for modification for this PR then only this PR will merge

@pinakviramgama
Copy link
Contributor Author

Dear @deepeshmlgupta , sir i tried my best to make previous changes revert , but sir i have not made any changes in other files and sir previous changes are not able to fetch, sorry sir for that.

please sir guide me now what should i do.

@pinakviramgama
Copy link
Contributor Author

sir @deepeshmlgupta , it could be due to the single blank spaces that i by mistake have pressed in other files so changes might have reflected but sir i have not made any other changes any other files

@pinakviramgama
Copy link
Contributor Author

pinakviramgama commented Nov 9, 2024

Sir @deepeshmlgupta , if you permit then can i delete those files from this PR which are not necessary so that if you merge this PR so that file changes won''t get reflected

Copy link

vercel bot commented Nov 9, 2024

Deployment failed with the following error:

Resource is limited - try again in 10 minutes (more than 100, code: "api-deployments-free-per-day").

@pinakviramgama
Copy link
Contributor Author

Sir @deepeshmlgupta , please guide me sir what should i do now, please sir guide me.

@deepeshmlgupta
Copy link
Collaborator

you can delete those files that are not need so that it can easy for me to review this

@deepeshmlgupta
Copy link
Collaborator

I am closing these PR so if you can delete those unrequited files than again reopen it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Pie chart generator
2 participants