perf: remove node cloning to improve performance

azat-io · Aug 5, 2024 · 00b2cc3 · 00b2cc3
1 parent 4130bc2
commit 00b2cc3
Show file tree

Hide file tree

Showing 19 changed files with 20 additions and 20 deletions.
diff --git a/rules/sort-array-includes.ts b/rules/sort-array-includes.ts
@@ -115,8 +115,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
                         ? `${element.value}`
                         : sourceCode.text.slice(...element.range),
                     size: rangeToDiff(element.range),
-                    node: structuredClone(element),
                     type: element.type,
+                    node: element,
                     group,
                   })
                 }

diff --git a/rules/sort-astro-attributes.ts b/rules/sort-astro-attributes.ts
@@ -169,8 +169,8 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
               }
 
               accumulator.at(-1)!.push({
-                node: structuredClone(attribute) as TSESTree.Node,
                 size: rangeToDiff(attribute.range),
+                node: attribute as TSESTree.Node,
                 group: getGroup(),
                 name,
               })

diff --git a/rules/sort-classes.ts b/rules/sort-classes.ts
@@ -387,8 +387,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
             let value = {
               size: rangeToDiff(member.range),
-              node: structuredClone(member),
               group: getGroup(),
+              node: member,
               dependencies,
               name,
             }

diff --git a/rules/sort-enums.ts b/rules/sort-enums.ts
@@ -127,7 +127,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
             let sortingNode = {
               size: rangeToDiff(member.range),
-              node: structuredClone(member),
+              node: member,
               name,
             }
             accumulator.at(-1)!.push(sortingNode)

diff --git a/rules/sort-exports.ts b/rules/sort-exports.ts
@@ -81,8 +81,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
     ) => {
       parts.at(-1)!.push({
         size: rangeToDiff(node.range),
-        node: structuredClone(node),
         name: node.source.value,
+        node,
       })
     }
 

diff --git a/rules/sort-imports.ts b/rules/sort-imports.ts
@@ -437,8 +437,8 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
 
       nodes.push({
         size: rangeToDiff(node.range),
-        node: structuredClone(node),
         group: computeGroup(node),
+        node,
         name,
         ...(options.type === 'line-length' &&
           options.maxLineLength && {

diff --git a/rules/sort-interfaces.ts b/rules/sort-interfaces.ts
@@ -198,7 +198,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
 
               let elementSortingNode = {
                 size: rangeToDiff(element.range),
-                node: structuredClone(element),
+                node: element,
                 name,
               }
 

diff --git a/rules/sort-intersection-types.ts b/rules/sort-intersection-types.ts
@@ -177,8 +177,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
         return {
           name: sourceCode.text.slice(...type.range),
           size: rangeToDiff(type.range),
-          node: structuredClone(type),
           group: getGroup(),
+          node: type,
         }
       })
 

diff --git a/rules/sort-jsx-props.ts b/rules/sort-jsx-props.ts
@@ -178,8 +178,8 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
 
               let jsxNode = {
                 size: rangeToDiff(attribute.range),
-                node: structuredClone(attribute),
                 group: getGroup(),
+                node: attribute,
                 name,
               }
 

diff --git a/rules/sort-maps.ts b/rules/sort-maps.ts
@@ -121,7 +121,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
               return {
                 size: rangeToDiff(element.range),
-                node: structuredClone(element),
+                node: element,
                 name,
               }
             })

diff --git a/rules/sort-named-exports.ts b/rules/sort-named-exports.ts
@@ -93,8 +93,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
           }
           return {
             size: rangeToDiff(specifier.range),
-            node: structuredClone(specifier),
             name: specifier.local.name,
+            node: specifier,
             group,
           }
         })

diff --git a/rules/sort-named-imports.ts b/rules/sort-named-imports.ts
@@ -114,7 +114,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
           return {
             size: rangeToDiff(specifier.range),
-            node: structuredClone(specifier),
+            node: specifier,
             group,
             name,
           }

diff --git a/rules/sort-object-types.ts b/rules/sort-object-types.ts
@@ -191,7 +191,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
 
               let memberSortingNode = {
                 size: rangeToDiff(member.range) - endSize,
-                node: structuredClone(member),
+                node: member,
                 name,
               }
 

diff --git a/rules/sort-objects.ts b/rules/sort-objects.ts
@@ -298,7 +298,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
               let propSortingNode = {
                 size: rangeToDiff(prop.range),
-                node: structuredClone(prop),
+                node: prop,
                 name,
               }
 

diff --git a/rules/sort-svelte-attributes.ts b/rules/sort-svelte-attributes.ts
@@ -176,7 +176,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
               }
 
               accumulator.at(-1)!.push({
-                node: structuredClone(attribute) as unknown as TSESTree.Node,
+                node: attribute as unknown as TSESTree.Node,
                 size: rangeToDiff(attribute.range),
                 group: getGroup(),
                 name,

diff --git a/rules/sort-switch-case.ts b/rules/sort-switch-case.ts
@@ -104,7 +104,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
             return {
               size: rangeToDiff(caseNode.test?.range ?? caseNode.range),
-              node: structuredClone(caseNode),
+              node: caseNode,
               name,
             }
           },
@@ -160,7 +160,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
               node: right.node,
               fix: fixer => {
                 let additionalFixes: TSESLint.RuleFix[] = []
-                let nodeGroups = structuredClone(nodes).reduce<
+                let nodeGroups = nodes.reduce<
                   SortingNode<TSESTree.SwitchCase>[][]
                 >(
                   (

diff --git a/rules/sort-union-types.ts b/rules/sort-union-types.ts
@@ -177,8 +177,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
         return {
           name: sourceCode.text.slice(...type.range),
           size: rangeToDiff(type.range),
-          node: structuredClone(type),
           group: getGroup(),
+          node: type,
         }
       })
 

diff --git a/rules/sort-variable-declarations.ts b/rules/sort-variable-declarations.ts
@@ -140,7 +140,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
           return {
             size: rangeToDiff(declaration.range),
-            node: structuredClone(declaration),
+            node: declaration,
             dependencies,
             name,
           }

diff --git a/rules/sort-vue-attributes.ts b/rules/sort-vue-attributes.ts
@@ -179,7 +179,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
               }
 
               accumulator.at(-1)!.push({
-                node: structuredClone(attribute) as unknown as TSESTree.Node,
+                node: attribute as unknown as TSESTree.Node,
                 size: rangeToDiff(attribute.range),
                 group: getGroup(),
                 name,