refactor: reduce JSON schema and options duplication #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces code duplication in 2 ways:
defaultOptions
. Creates a single constant for that per rule.type
,order
, etc. Put these in common in autils/common-json-schemas.ts
file.Here is the list of JSON schemas attributes put in common:
type
order
matcher
ignoreCase
specialCharacters
groups
customGroups
(Object-based API)partitionByComment
No other code logic or tests have been touched.
Other changes
complete
return a new object rather than usingObject.assign
.What is the purpose of this pull request?