fix: handle more complex expressions in sort-objects #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3e987ae fixes references to dependencies/earlier params (#9), but not in some more complex cases. Examples are provided in tests.
Additional context
Do you think this is a good approach? I think we should try to search all of the nested nodes for
Identifier
s, which would be pushed to thedependencies
array. I'm not sure I covered all the possible cases with this approach.The tests also probably need some more work on the semantics :)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).