[GENERAL] Spell effect looks like duplicate in spell.cpp #3889
BarbzYHOOL
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Here are the spells using these spell effects:
Spell effect 85 (SPELL_EFFECT_SUMMON_PLAYER):
7720 = warlock summon spell effect (probably not the spell players use)
48955 = recruit a friend summon spell
Spell effect 152 (SPELL_EFFECT_SUMMON_RAF_FRIEND):
45927 = recruit a friend summon spell wrapper (probably the spell players use but not sure)
In spell.cpp around line 6044 at
case SPELL_EFFECT_SUMMON_PLAYER:
, there is some code.and right below there is
case SPELL_EFFECT_SUMMON_RAF_FRIEND:
and it's approximatively the same code. Please open the file to understandhowever, the spell affected for case "SPELL_EFFECT_SUMMON_RAF_FRIEND" is 45927 which is a wrapper around spell 48955 so everything in the case "SPELL_EFFECT_SUMMON_PLAYER" is applied to that spell 48955 (I mean, I tried with the access_requirement table and it prevented me from summoning a player with both spells). So I don't know, it seems like this part of the code is kinda useless BUT it could be used if someone created a custom spell with SPELL_EFFECT_SUMMON_RAF_FRIEND lol (pretty unlikely).
What do you think?
Beta Was this translation helpful? Give feedback.
All reactions