Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Creature) - Darkfang Venomspitter under the map #20597

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

TheSCREWEDSoftware
Copy link
Contributor

@TheSCREWEDSoftware TheSCREWEDSoftware commented Nov 16, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue

  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

  • .go xyz -3215.17 -3649.05 52.9613 1 4.08407 for 18622
    and

  • .go xyz -2572.63 -3742.22 31.0639 1 2.47837 for 7887

Known Issues and TODO List:

  • Sniff? For the both NPCs have no path/patrol

@github-actions github-actions bot added the DB related to the SQL database label Nov 16, 2024
@Rorschach91 Rorschach91 added the Tested This PR has been tested and is working. label Nov 16, 2024
@Rorschach91
Copy link
Contributor

I don't think that a sniff is needed.
PR tested. It works.

@TheSCREWEDSoftware
Copy link
Contributor Author

I don't think that a sniff is needed. PR tested. It works.

Even if they don't move? they dont have path/patrol associated to them. They do follow you and attack, but they dont wonder

@heyitsbench
Copy link
Contributor

A sniff would eventually be nice to respawn these guys from scratch, but for now it gets them out of the ground, so it's good enough.

@Rorschach91 Rorschach91 merged commit e21ab70 into azerothcore:master Nov 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database Tested This PR has been tested and is working. To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dustwallow Marsh] Darkfang Venomspitter underneath terrain. [NPC] Darkfang Venomspitter underneath terrain
3 participants