When bidding, bot uses the wrong pricing method.

[steenburgh]

Perhaps I'm mistaken, but it looks like this line of code was meant to have a !. I'd make a PR but I'm not familiar enough with the code to be sure I'm correct.

The config says:

#    AuctionHouseBot.UseBuyPriceForBuyer
#        Should the Buyer use BuyPrice or SellPrice to determine Bid Prices
#    Default 0 (use SellPrice)

But the code seems to do the opposite:

mod-ah-bot/src/AuctionHouseBot.cpp

Lines 569 to 596 in 45cdc1c

	if (BuyMethod)
	{
	if (prototype->Quality <= AHB_MAX_QUALITY)
	{
	if (currentprice < prototype->SellPrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality))
	bidMax = prototype->SellPrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality);
	}
	else
	{
	// quality is something it shouldn't be, let's get out of here
	if (debug_Out) sLog->outError( "AHBuyer: Quality %u not Supported", prototype->Quality);
	continue;
	}
	}
	else
	{
	if (prototype->Quality <= AHB_MAX_QUALITY)
	{
	if (currentprice < prototype->BuyPrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality))
	bidMax = prototype->BuyPrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality);
	}
	else
	{
	// quality is something it shouldn't be, let's get out of here
	if (debug_Out) sLog->outError( "AHBuyer: Quality %u not Supported", prototype->Quality);
	continue;
	}
	}

[mserajnik]

This seems to still be an issue:

mod-ah-bot/src/AuctionHouseBot.cpp

Lines 566 to 596 in c34c10a

	// check that bid has acceptable value and take bid based on vendorprice, stacksize and quality
	if (BuyMethod)
	{
	if (prototype->Quality <= AHB_MAX_QUALITY)
	{
	if (currentprice < prototype->SellPrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality))
	bidMax = prototype->SellPrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality);
	}
	else
	{
	// quality is something it shouldn't be, let's get out of here
	if (debug_Out)
	LOG_ERROR("module", "AHBuyer: Quality {} not Supported", prototype->Quality);
	continue;
	}
	}
	else
	{
	if (prototype->Quality <= AHB_MAX_QUALITY)
	{
	if (currentprice < prototype->BuyPrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality))
	bidMax = prototype->BuyPrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality);
	}
	else
	{
	// quality is something it shouldn't be, let's get out of here
	if (debug_Out)
	LOG_ERROR("module", "AHBuyer: Quality {} not Supported", prototype->Quality);
	continue;
	}
	}

It is checked if BuyMethod is true, which is the case when the configuration AuctionHouseBot.UseBuyPriceForBuyer is set to true.

But then it proceeds to use prototype->SellPrice there and prototype->BuyPrice when BuyMethod is false, so this seems to be reversed by mistake.

Can one of the maintainers confirm if this is correct or not? @Winfidonarleyan perhaps?

[Winfidonarleyan]

Remind me to watch on Saturday, Discord or here via ping me

[WuStangDan]

Yes this bug is still here. I tested it in game to confirm (after being suspicious that a few high sells were going through) and yes even when setting in the config AuctionHouseBot.UseBuyPriceForBuyer = 0 it uses the buy price, not the sell price for the buyer.

This means that there are plenty of situations where you could create a money pump with this bot. Buying items from the bot and selling back at a much higher price.

Love the mod overall though, thanks.