Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of the selling priority, following item quality instead of a random pick #104

Merged
merged 9 commits into from
Sep 14, 2024

Conversation

kewinrausch
Copy link

Changes Proposed:

  • The selection of items to sold in the auction house has been changes from a random pick to a priority approach. Instead of relying on a random pick which can waste cycles, the configured quotas are met in order of quality, starting from the poor items and ending with artifacts. This cause the bot to pick items in order.

Issues Addressed:

  • No fixes addressed

SOURCE:

Tests Performed:

  • The code build with no errors.
  • Tested on my private server; there are no really visible changes since the configured quotas keeps the number of items at the same level.

How to Test the Changes:

  1. Pull the code and compile it within your installation.
  2. Configure the bot to sell low items per cycle.
  3. Observe the auction house growing; you will see uncommon items spawning firsts, as it should be in a normal market, and more uncommon and rare items appears later during the day.

…mand line (cleanup and initialization of new elements)
…ces (right now is a plain average which resets to allow quick convergence with the markets sentiments)
… a random pickup, which can always result in bad rolls and waste of cycles, the selling priority now follows the items rarity. First the bot will try to fill up poor items, and then when quotas are reached it will move to more rare ones
@Helias Helias merged commit 29ae6b0 into azerothcore:master Sep 14, 2024
1 check passed
@Helias
Copy link
Member

Helias commented Sep 14, 2024

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants