Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flight speed related auras #139

Merged

Conversation

sogladev
Copy link

@sogladev sogladev commented Sep 29, 2024

Changes Proposed:

Rename flight speed related auras from azerothcore/azerothcore-wotlk#20079

206 SPELL_AURA_MOD_INCREASE_VEHICLE_FLIGHT_SPEED -> SPELL_AURA_MOD_INCREASE_FLIGHT_SPEED
208 SPELL_AURA_MOD_INCREASE_FLIGHT_SPEED -> SPELL_AURA_MOD_FLIGHT_SPEED_ALWAYS
210 SPELL_AURA_MOD_VEHICLE_SPEED_ALWAYS -> SPELL_AURA_MOD_FLIGHT_SPEED_NOT_STACKING

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@sogladev sogladev marked this pull request as draft September 29, 2024 21:28
@sogladev sogladev marked this pull request as ready for review September 29, 2024 21:31
@55Honey 55Honey merged commit b7227f6 into azerothcore:master Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants