Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix. Delete quest items after completing it #26

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

pangolp
Copy link
Contributor

@pangolp pangolp commented Feb 22, 2024

Changes Proposed:

  • Currently, when adding items to the player's bag, it may happen that the player obtains more items than the quest needs. Therefore, when it is completed, the items must be removed from the bag, and from the player's bank.
  • We are only going to eliminate certain items. Because there are some, I know that they can be obtained and used in missions, which do not have to be eliminated, since they can be sold and traded with them.

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

  • Windows 10
  • In-game

How to Test the Changes:

  1. Create a character or choose a quest that requires items from an NPC.
  2. Obtain more items from the account, and complete the mission. As an additional bonus, you can leave part of the items in the bank, to verify that they are also eliminated.
  3. Upon completing the quest and obtaining the reward, the items in the player's bag and bank are eliminated. (the leftovers).

Items, whose boding is 0, are not deleted.
Only those that have the same one with the value 4.

 entry  name                                   bonding  
------  -------------------------------------  ---------
  2725  Green Hills of Stranglethorn - Page 1          0
  3901  Bloodscalp Tusk                                4
  8483  Wastewander Water Pouch                        0
 29906  Vashj's Vial Remnant                           4
 50432  Diseased Wolf Pelt                             4

@pangolp pangolp merged commit 3744bb6 into azerothcore:master Feb 22, 2024
1 check passed
@pangolp pangolp deleted the items branch February 24, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant