Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix. Close the loot bag when taking the gold #33

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix. Close the loot bag when taking the gold #33

merged 1 commit into from
Mar 12, 2024

Conversation

pangolp
Copy link
Contributor

@pangolp pangolp commented Mar 12, 2024

Changes Proposed:

  • As described in the video, currently, due to the latest changes, we were missing closing the loot bag to the player, when the loot is gold. It's a visual error, however, we had to correct it anyway. I didn't add extra gold or anything like that, but it's not okay for the bag to be left open after taking the loot. It only happened with the client's auto stripping activated, because if the auto stripping was not there, there were no problems.
  • I moved some pointers around, just so they are all together, but I don't think they change the logic of the problem.

Issues Addressed:

SOURCE:

Tests Performed:

  • Windows 10
  • In-game

How to Test the Changes:

  1. With 1 account alone or with 2 people in a group, kill a series of enemies, and activate the automatic looting of the client.
  2. You should get all the items in the bag, and the loot menu should close.

@pangolp pangolp merged commit 219d929 into master Mar 12, 2024
1 check passed
@pangolp pangolp deleted the gold branch March 12, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Sometimes, the loot window is stuck showing gold that cannot be looted
1 participant