Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4 methods #158

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Add 4 methods #158

merged 5 commits into from
Jan 28, 2024

Conversation

worldofd2
Copy link

@worldofd2 worldofd2 commented Oct 27, 2023

1:
Player:GetAchievementPoints

2:
Player:GetCompletedQuestsCount
This should have been GetCompletedQuestsCount, not sure how to update that now.

3: You also have an option to include feats of strength or not (not included by default, blizzard like)
Player:GetCompletedAchievementsCount

4: RegisterPlayerEvent
OnCreatureKilledByPet

Roboto made GetAchievementPoints and I added GetCompletedQuestCount
RegisterPlayerEvent  58
@55Honey
Copy link
Member

55Honey commented Oct 28, 2023

Hi and thanks for your PR. We'll look into it asap.

@worldofd2
Copy link
Author

Please let me know if a better format should be used, first time for a PR.
Thank you.

@kissingers
Copy link

I tested 3 about achievement and question, it seems ok

		local pAchivePoint = player:GetAchievementPoints()
		local pAchiveCompleted = player:GetCompletedAchievementsCount()	
		local pCompletedQuest = player:GetCompletedQuestsCount()			
		player:SendBroadcastMessage("Your achievement points is "..pAchivePoint)
		player:SendBroadcastMessage("you completed "..pAchiveCompleted.." achievements")
		player:SendBroadcastMessage("you completed "..pCompletedQuest.." quests (without everyday quests)")	

image
image
image

.gitignore Outdated Show resolved Hide resolved
@Nyeriah Nyeriah merged commit fe1b709 into azerothcore:master Jan 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants