Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add GetGlyph #178

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

Tralenor
Copy link

@Tralenor Tralenor commented Jun 2, 2024

adds player:GetGlyph(slotIndex) (requested by @55Honey in #152 (comment)_)

how to test

add a scripting file with:

local function OnPlayerCommand(event, player, command)
  if (command == "add_glyph") then
        print("reached_command: add glyph")
        player:SetGlyph(190,0)
        player:SetGlyph(702,3)

        player:Say("glyph in slot 0: "..player:GetGlyph(0),0)

        player:Say("glyph in slot 1: "..player:GetGlyph(1),0)

        player:Say("glyph in slot 3: "..player:GetGlyph(3),0)
        return false
    end
end

RegisterPlayerEvent(42, OnPlayerCommand)

On a paladin execute command ".add_glyph" in chat
Check that output matches input as written in script (190,0,702)

also credit to @kissingers who created a PR on this topics on the same day. #177

@kissingers
Copy link

Good, so I can call back my pull...

@Tralenor
Copy link
Author

Tralenor commented Jun 3, 2024

Good, so I can call back my pull...

@kissingers Oh sorry, I did not see that you created one yesterday as well. If you prefer I can close this one and you could re-open yours.

@kissingers
Copy link

It seems your code and doc more good than me, so need not re-open.

@55Honey
Copy link
Member

55Honey commented Jun 11, 2024

Thanks for the PR!

@55Honey 55Honey merged commit 067fa20 into azerothcore:master Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants