Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused variable warning in GlobalMethods:Ban() #183

Merged
merged 5 commits into from
Jul 7, 2024

Conversation

sudlud
Copy link
Member

@sudlud sudlud commented Jul 4, 2024

No description provided.

@55Honey
Copy link
Member

55Honey commented Jul 4, 2024

Let's get rid of what's not required for AC all together.

There was a reorganisation of the Eluna master repo. Each core now has its own set of files without the need of ifdefs in each file. That's to be ported, but we can start anywhere.

@sudlud
Copy link
Member Author

sudlud commented Jul 5, 2024

@55Honey i'm reworking this to drop all non-AC-relevant code so we will get rid of most #if #else #endif blocks

should I go as far as assuming we are at AZEROTHCORE with WOTLK beeing set and remove any code related to e.g. CLASSIC/TBC/MISTS/MANGOS/TRINITY/...?

there's a lot of switches depending on the expansion define, but for AC this would always be set to WOTLK?

or would this go too far?

@55Honey
Copy link
Member

55Honey commented Jul 5, 2024

In short: yes.

There was a closed PR lately, which wasn't merged because it was closed before we had a chance to review it, which claimed to remove all the ifdefs. I am not sure if you can dig it up so we can diff-merge.

@sudlud sudlud changed the title handle unused variable in Ban() correctly drop all non-AC/WOTLK related code within #if-blocks Jul 5, 2024
@sudlud
Copy link
Member Author

sudlud commented Jul 5, 2024

alright then i might need to revisit this within the next days, for now it removes almost all #if blocks

@sudlud sudlud changed the title drop all non-AC/WOTLK related code within #if-blocks Fix unused variable warning in GlobalMethods:Ban() Jul 7, 2024
@sudlud sudlud merged commit b39869a into azerothcore:master Jul 7, 2024
1 check failed
@sudlud sudlud deleted the handle-unused-variable-in-ban-1 branch July 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants