Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SQL script to use the create_template_model/Feature: level-appropriate buffs #30

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix: SQL script to use the create_template_model/Feature: level-appropriate buffs #30

merged 2 commits into from
Jul 2, 2024

Conversation

pappons
Copy link
Contributor

@pappons pappons commented Jul 1, 2024 •
edited
Loading

Changes Proposed:

  • Feature: Switched hard-coded spell ids to use spell chains so it picks a more level appropriate spell
  • Feature: Added Thorns to the spell list

Issues Addressed:

  • Fixes SQL script incompatibility with updated table structure.

Tests Performed:

  • Built and without errors on Linux x86_64
  • Tested buff NPC in-game on several characters at various levels on two accounts

How to Test the Changes:

  1. Run SQL script to validate it doesn't fail regarding the now removed modelid1 column
  2. Enable and place NPC according to guidelines described in the module's readme.md
  3. Interact with NPC with characters at various levels to confirm that they get level-appropriate buffs

@pappons
Fix: Updated the SQL script to use the create_template_model table
4c3f353 
Feature: Switched hard-coded spell ids to use spell chains so it picks a more level appropriate spell
Feature: Added Thorns to the spell list
@pappons
Removed unused variable
f34c1de
@pappons pappons changed the title Fix: Updated the SQL script to use the create_template_model table Fix: SQL script to use the create_template_model/Feature: level-appropriate buffs Jul 1, 2024
@Nyeriah Nyeriah merged commit 952533a into azerothcore:master Jul 2, 2024
1 check passed
@pappons pappons deleted the feature/Update-spell-list-to-use-spell-chains-for-scaling branch July 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyeriah Nyeriah Nyeriah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pappons @Nyeriah