Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SoloCraft): exclude map/instance from Solocraft scaling with conf #50

Merged

Conversation

valsan-azerty-boi
Copy link

@valsan-azerty-boi valsan-azerty-boi commented Sep 5, 2024

Changes Proposed:

  • Feature: Add the possibility to exclude somes map/instances from the scaling of Solocraft
  • In my case I use it for a map like Alterac BG because i don't want player scaling in this

Issues Addressed:

  • N/A

Tests Performed:

  • Build on Debian 11 OK
  • Github workflow OK on my branch
  • In game tests (see below)

How to Test the Changes:

Test with excluded maps:

  1. Use Solocraft.Instance.Excluded = "30,489,529,559,562,566,572,607,617,618,628" in Solocraft.conf
  2. Run server
  3. Queue a 80 character for Alterac (map 30)
  4. Enter and see peoples with normal stats
    image
    image

Test without excluded maps:

  1. Use Solocraft.Instance.Excluded = "" in Solocraft.conf
  2. Run server
  3. Queue a 80 character for Alterac (map 30)
  4. Enter and see peoples with scaled stats
    image
    image

Sorry if my english is not in a very good state, not my native lang.
And I'm not a very C++ dev so I can make a lot of mistake, forgive me.

@valsan-azerty-boi valsan-azerty-boi marked this pull request as ready for review September 5, 2024 19:57
@valsan-azerty-boi valsan-azerty-boi changed the title Exclude map/instance from Solocraft scaling with conf Feature: exclude map/instance from Solocraft scaling with conf Sep 5, 2024
@valsan-azerty-boi valsan-azerty-boi changed the title Feature: exclude map/instance from Solocraft scaling with conf feat(Solo): exclude map/instance from Solocraft scaling with conf Sep 5, 2024
@valsan-azerty-boi valsan-azerty-boi changed the title feat(Solo): exclude map/instance from Solocraft scaling with conf feat(SoloCraft): exclude map/instance from Solocraft scaling with conf Sep 5, 2024
@valsan-azerty-boi
Copy link
Author

https://github.com/azerothcore/mod-solocraft/pull/50/checks
PR workflow/build OK :)

@Helias Helias merged commit a1902a8 into azerothcore:master Sep 6, 2024
1 check passed
@Helias
Copy link
Member

Helias commented Sep 6, 2024

thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants