Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump up cosmos sdk v0.50.x and cometbft v0.38.0 #1

Closed
wants to merge 16 commits into from
Closed

feat: bump up cosmos sdk v0.50.x and cometbft v0.38.0 #1

wants to merge 16 commits into from

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Nov 14, 2023

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2
feat: update go.mod
d231c75 
cosmos-sdk v0.47.0
cometbft v0.37.0
cometbft-db v0.7.0
ibc-go/v7 v7.0.0
cosmos-proto v1.0.0-beta.2 (downgrade)
cosmossdk.io/simapp v0.0.0-20230323161446-0af178d721fffeat: bump up ibc-go/v7 v7.0.0
@dudong2
build: go mod tidy
f6e0bfd
@dudong2
build: fix build errors
4e7b8e9
@dudong2
test: fix tests
5f71660
@zsystm
Copy link
Collaborator

zsystm commented Nov 15, 2023 •
edited
Loading

I think we should consider updating [app/upgrades.go] to latest one in Cronos ethermint also.

Cronos added upgrades.go in crypto-org-chain#278
and updated it when updating ibc-go to v7.0.1 (crypto-org-chain#306)

@zsystm
Copy link
Collaborator

zsystm commented Nov 15, 2023

non-critical & trivial comment:
Changing string ethermint_9000-1 to a constant ChainID(already defined) would be great.
https://github.com/b-harvest/ethermint/pull/1/files#diff-da38dc05011a3262fbf1f4b208af7960ba5d65f6d739876073904c55118e3764L91

@dudong2
Copy link
Collaborator Author

dudong2 commented Nov 15, 2023

non-critical & trivial comment: Changing string ethermint_9000-1 to a constant ChainID(already defined) would be great. https://github.com/b-harvest/ethermint/pull/1/files#diff-da38dc05011a3262fbf1f4b208af7960ba5d65f6d739876073904c55118e3764L91

Fixed with reference to crypto-org-chain/ethermint pr(crypto-org-chain#278)

@zsystm
Copy link
Collaborator

zsystm commented Nov 15, 2023 •
edited
Loading

(Resolved)
suggestion:
When chanID is not set by flag, reading it from config looks great practice.
https://github.com/crypto-org-chain/ethermint/pull/278/files#diff-e5ad063aa68d7aeceef2a6e2756b5fbbe1761c25dcb4722997d35aa527b30b94R253-R268

dudong2 and others added 10 commits November 15, 2023 14:13
@dudong2
feat: apply cosmos-sdk v0.47.x upgrade docs
bb69d1b
@dudong2
docs: update gomod2nix.toml
04f032b
@mmsqe @dudong2
Problem: localhost client param is not migrated (evmos#306)
caf3d78 
* Problem: localhost client param is not migrated

for more info, https://github.com/cosmos/ibc-go/blob/v7.2.0/docs/migrations/v7-to-v7_1.md

* add test

* fix test

* WithConsensusParamsGetter to MigrationModuleManager
@mmsqe @dudong2
Problem: recent version of SetPreBlocker is not used (evmos#326)
2ac0e19
@mmsqe @yihuang @dudong2
feat: support blocking list of addresses in mempool and disable vesti…
1533fc1 
…ng messages in check tx mode (evmos#327)

* small fixes (evmos#310)

* disable vesting account messages in check tx

* Problem: don't support blocking addresses

Solution:
- support block addresses in mempool

* fix error

* put block address logic after validate basic

* fix build

* Apply suggestions from code review

Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>

* rm IsCheckTx check

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
@dudong2
Revert blocking list feature from "feat: support blocking list of add…
6a8ad57 
…resses in mempool and disable vesting messages in check tx mode (evmos#327)"

This reverts commit 1533fc1.
@yihuang @dudong2
Problem: performance regression because of un-cached sender recovery (e…
f0c4147 
…vmos#350)

Solution:
- re-order ante handlers, use cached from address
@dudong2
Revert antehandler ordering from "Problem: performance regression bec…
14d731b 
…ause of un-cached sender recovery (evmos#350)"

This reverts commit f0c4147.
@yihuang @dudong2
fix negative dynamic fee (evmos#351)
15326be 
* fix negative dynamic fee

* Update app/ante/fee_checker.go

Signed-off-by: yihuang <huang@crypto.com>

* fix build

---------

Signed-off-by: yihuang <huang@crypto.com>
@dudong2
test: fix lint
a1390fc
@dudong2 dudong2 closed this Nov 29, 2023
@dudong2 dudong2 deleted the dudong2/feat/cosmos-sdk@v0.50.x-cometbft@v0.38.0 branch January 22, 2024 07:40
dongsam pushed a commit that referenced this pull request Jul 25, 2024
@tkkwon1998
Merge pull request #1 from Canto-Network/v0.19.3-hotfix-rpc
db8920e 
fix(evm,rpc): coinbase should not be the current one in traceTransact…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:CLI C:Crypto C:Encoding C:Proto C:Types Type: Build Type: CI Type: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dudong2 @zsystm @mmsqe @yihuang