Abstract away SearchMethodsForLocalizationMessagesRule (#130)

ba-st · Aug 27, 2024 · af3ccb2 · af3ccb2
1 parent 033ddb5
commit af3ccb2
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 8 deletions.
diff --git a/source/Buoy-Development-Tools-Pharo-12/NaturalLanguageTranslationScanner.class.st b/source/Buoy-Development-Tools-Pharo-12/NaturalLanguageTranslationScanner.class.st
@@ -82,12 +82,6 @@ NaturalLanguageTranslationScanner >> projectName [
 { #category : 'private' }
 NaturalLanguageTranslationScanner >> scanProjectMethodsCollectingTranslationsIn: stringsToTranslate [
 
-  | searchRule |
-  searchRule := RBParseTreeLintRule new.
-  searchRule matcher
-    matches: '`#string localized'
-    do: [ :node :answer | stringsToTranslate add: node receiver value ];
-    matches: '`#string localizedWithAll: `@values'
-    do: [ :node :answer | stringsToTranslate add: node receiver value ].
-  searchRule runOnEnvironment: environment
+  ( SearchMethodsForLocalizationMessagesRule collectingTranslationsIn: stringsToTranslate )
+    runOnEnvironment: environment
 ]
diff --git a/source/Buoy-Development-Tools-Pharo-12/SearchMethodsForLocalizationMessagesRule.class.st b/source/Buoy-Development-Tools-Pharo-12/SearchMethodsForLocalizationMessagesRule.class.st
@@ -0,0 +1,38 @@
+Class {
+	#name : 'SearchMethodsForLocalizationMessagesRule',
+	#superclass : 'RBParseTreeLintRule',
+	#instVars : [
+		'stringsToTranslate'
+	],
+	#category : 'Buoy-Development-Tools-Pharo-12',
+	#package : 'Buoy-Development-Tools-Pharo-12'
+}
+
+{ #category : 'instance creation' }
+SearchMethodsForLocalizationMessagesRule class >> collectingTranslationsIn: aCollection [
+
+  ^ self new initializeCollectingTranslationsIn: aCollection
+]
+
+{ #category : 'initialization' }
+SearchMethodsForLocalizationMessagesRule >> initialize [
+
+  super initialize.
+  matcher
+    matches: '`#string localized'
+    do: [ :node :answer | stringsToTranslate add: node receiver value ];
+    matches: '`#string localizedWithAll: `@values'
+    do: [ :node :answer | stringsToTranslate add: node receiver value ]
+]
+
+{ #category : 'initialization' }
+SearchMethodsForLocalizationMessagesRule >> initializeCollectingTranslationsIn: aCollection [
+
+  stringsToTranslate := aCollection
+]
+
+{ #category : 'accessing' }
+SearchMethodsForLocalizationMessagesRule >> name [
+
+  ^ 'Search methods for localization messages'
+]