Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup polyglot translator #128

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Conversation

mtabacman
Copy link
Member

PolyglotNaturalLanguageTranslator was being sent the cleanUp method by NaturalLanguageTranslator class>>#cleanUp when an image clean up was requested.

@mtabacman mtabacman requested a review from gcotelli July 8, 2024 16:09
@mtabacman mtabacman self-assigned this Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (57e1b32) to head (dc464a8).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-candidate      #128   +/-   ##
===================================================
  Coverage             100.00%   100.00%           
===================================================
  Files                     95        95           
  Lines                   8318      8318           
===================================================
  Hits                    8318      8318           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcotelli gcotelli merged commit 5da4215 into release-candidate Jul 10, 2024
64 checks passed
@gcotelli gcotelli deleted the cleanup-polyglot-translator branch July 10, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants