Improve portability

ba-st · Aug 31, 2023 · b32cf26 · b32cf26
1 parent 61b0822
commit b32cf26
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 6 deletions.
diff --git a/source/Hyperspace-Extensions/ZnMimeType.extension.st b/source/Hyperspace-Extensions/ZnMimeType.extension.st
@@ -3,9 +3,10 @@ Extension { #name : #ZnMimeType }
 { #category : #'*Hyperspace-Extensions' }
 ZnMimeType >> accepts: aMimeType [
 
-	^ (aMimeType main = '*' or: [ aMimeType main = self main ])
-		and: [ aMimeType sub = '*'
-				or: [ self sub = aMimeType sub or: [ (self sub splitOn: $+) includes: aMimeType sub ] ] ]
+	^ (aMimeType main = '*' or: [ aMimeType main = self main ]) and: [
+		  aMimeType sub = '*' or: [
+			  self sub = aMimeType sub or: [
+				  ($+ split: self sub) includes: aMimeType sub ] ] ]
 ]
 
 { #category : #'*Hyperspace-Extensions' }

diff --git a/source/Hyperspace-Model-Tests/ZnRequestHyperspaceExtensionsTest.class.st b/source/Hyperspace-Model-Tests/ZnRequestHyperspaceExtensionsTest.class.st
@@ -69,7 +69,7 @@ ZnRequestHyperspaceExtensionsTest >> testQuery [
 
 	request := ZnRequest query: self googleUrl / 'search'.
 
-	self assert: request method equals: #QUERY.
+	self assert: request method equals: 'QUERY'.
 	output := String streamContents: [ :s | request writeOn: s ].
 
 	self

diff --git a/source/Hyperspace-Model/PortAvailabilityChecker.class.st b/source/Hyperspace-Model/PortAvailabilityChecker.class.st
@@ -35,7 +35,7 @@ PortAvailabilityChecker >> isAvailableForTCP: portNumber [
 	^ [ 
 	  | socket |
 
-	  socket := Socket newTCP.
+	  socket := ZnNetworkingUtils default socketClass newTCP.
 	  ZnNetworkingUtils default setServerSocketOptions: socket.
 	  socket listenOn: portNumber.
 	  [ 

diff --git a/source/Hyperspace-Model/WebLink.class.st b/source/Hyperspace-Model/WebLink.class.st
@@ -258,7 +258,8 @@ WebLink >> quoteValueWhenNeeded: aString [
 	"Values including ; or , needs to be quoted"
 
 	self assertNotEmpty: aString.
-	^ ( aString includesAnyOf: ';,' ) then: [ '"<1s>"' expandMacrosWith: aString ]
+	^ ((aString includes: $;) or: [ aString includes: $, ])
+		  then: [ '"<1s>"' expandMacrosWith: aString ]
 		  otherwise: [ aString ]
 ]
 

diff --git a/source/Hyperspace-Pharo-Extensions/ZnNetworkingUtils.extension.st b/source/Hyperspace-Pharo-Extensions/ZnNetworkingUtils.extension.st
@@ -0,0 +1,7 @@
+Extension { #name : #ZnNetworkingUtils }
+
+{ #category : #'*Hyperspace-Pharo-Extensions' }
+ZnNetworkingUtils >> socketClass [
+
+	^ Socket
+]