feat: Add logging and tracing middleware and slight reorg #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
May 5, 2024
KonradStaniec
approved these changes
May 6, 2024
| "log/slog" | ||
| "github.com/babylonchain/covenant-signer/signerservice/handlers" | ||
| "github.com/babylonchain/covenant-signer/signerservice/types" | ||
| logger "github.com/rs/zerolog" |
There was a problem hiding this comment.
I find this change a bit controversial tbh. Mainly:
- There is already good structured logging lib in standard lib (
slog). Imo it is better to minimze amount of dependendcies. - Using global object is also a bit bad, as it introduces global state.
Not a blocker for this pr as I understand this makes it consistent with staking api, but nevertheless we can re-think this at some point.
There was a problem hiding this comment.
Makes sense, created #12 to track it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logging and tracing middleware to be able to track faults. The middlewares is copied from the staking API service, with the only difference that I removed the
WrapWithSpantracing method as it is not used.Also, replaced slog with zerolog as it seemed easier to maintain with the logging middleware.
This PR also does a slight re-org of the files into directories, similar to what the staking API service does. While it should have been a separate PR, the changes were intertwined during my local development, but I can split them if you feel the PR context is too wide.
Partially resolves #9 . Did not add CORS middleware in this PR though.