R/test utils #70
R/test utils #70
Conversation
Update schema
Remove original (ignored) test
Remove original (ignored) test
Use test-utils test-helpers
Allow access to it from the lib feature Refactor get_params to staking_params for clarity
| # feature for enabling the full validation | ||
| full-validation = [ "btc-staking/full-validation" ] |
There was a problem hiding this comment.
Does the finality contract need the option for full validation? I thought the full validation is only relevant for Babylon <-> contract interaction, and only BTC staking contracts needs to have that. In theory finality contract can work with BTC staking contract with or without full validation.
For testing finality contract, we can always use BTC staking contract without full validation imo
There was a problem hiding this comment.
Yes, but this is a stronger setting, in which we confirm the full-validation feature works also in / for the multi-contract tests.
In fact all this comes from the fact that CI was running workspace tests with the full validation feature enabled, and they were failing for the finality contract.
I've now enabled that back, and tests are passing.
There was a problem hiding this comment.
I see. Is there a way to make this feature only for developments/tests? np with me if we cannot do it though
There was a problem hiding this comment.
It's already like that. Because the code under the library feature, used when importing other contracts, is only used / invoked from test code. These high level full-validation features in contracts other than the staking contract are just wrappers to the staking one; so that the feature can be enabled on purpose. Which, only affects tests.
| # feature for enabling the full validation | ||
| full-validation = [ "btc-staking/full-validation" ] |
There was a problem hiding this comment.
I see. Is there a way to make this feature only for developments/tests? np with me if we cannot do it though
maurolacy
force-pushed
the
r/test-utils
branch
from
873e992
to
5f42c3b
Compare
Refactor test utilities so that they are common to the contracts.
Also fixes the finality tests under the
full-validationfeature.