Add s3 diagnostic management command #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emnoor-reef
force-pushed
the
s3-diag
branch
2 times, most recently
from
52e0aa2 to
5c5a90c
Compare
mpnowacki-reef
requested changes
Jan 3, 2025
validator/app/src/compute_horde_validator/validator/management/commands/check_s3_setup.py
Outdated
Show resolved
Hide resolved
mpnowacki-reef
approved these changes
Jan 7, 2025
kkowalski-reef
approved these changes
Jan 8, 2025
| aws_secret_access_key = settings.AWS_SECRET_ACCESS_KEY | ||
| if endpoint_url is None: | ||
| endpoint_url = settings.AWS_ENDPOINT_URL | ||
|
|
There was a problem hiding this comment.
Isnt' AWS_DEFAULT_REGION missing here or is this on purpose?
There was a problem hiding this comment.
This is on purpose. We currently don't have any settings for setting region. I added the region in the diagnostic to check if existing environment variables are messing up the settings (boto3 reads from env when not explicitly mentioned).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.