-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary scoring formula #368
base: master
Are you sure you want to change the base?
Conversation
It takes organic jobs and properly rejected synthetic jobs into account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't include dancing because we've talked about it after this PR was submitted, right?
), | ||
"DYNAMIC_REJECTED_SYNTHETIC_JOB_SCORE": ( | ||
1.0, | ||
"Score for each properly rejected synthetic job", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ I was about to ask you to add that param, after talking with people
Adding the organic jobs to the scoring was implemented in a wrong way, that messed up executor class weights normalization. :(
No description provided.