refactor - description changed to base class.

badges · Oct 23, 2024 · 2537aea · 2537aea
1 parent 7fc89c3
commit 2537aea
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/services/scoop/scoop-base.js b/services/scoop/scoop-base.js
@@ -10,7 +10,7 @@ const bucketsSchema = Joi.object()
   .pattern(/.+/, Joi.string().pattern(gitHubRepoRegExp).required())
   .required()
 
-export default class ScoopBase extends ConditionalGithubAuthV3Service {
+export class ScoopBase extends ConditionalGithubAuthV3Service {
   async fetch({ app, schema }, queryParams) {
     if (!this.buckets) {
       this.buckets = await fetchJsonFromRepo(this, {
@@ -68,3 +68,6 @@ export default class ScoopBase extends ConditionalGithubAuthV3Service {
     }
   }
 }
+
+export const description =
+  "App's containing bucket. Can either be a name (e.g `extras`) or a URL to a GitHub Repo (e.g `https://github.com/jewlexx/personal-scoop`)"
diff --git a/services/scoop/scoop-license.service.js b/services/scoop/scoop-license.service.js
@@ -2,7 +2,7 @@ import Joi from 'joi'
 import { pathParam, queryParam } from '../index.js'
 import { renderLicenseBadge } from '../licenses.js'
 import toArray from '../../core/base-service/to-array.js'
-import ScoopBase from './scoop-base.js'
+import { description, ScoopBase } from './scoop-base.js'
 
 const scoopLicenseSchema = Joi.object({
   license: Joi.alternatives()
@@ -42,8 +42,7 @@ export default class ScoopLicense extends ScoopBase {
           pathParam({ name: 'app', example: 'ngrok' }),
           queryParam({
             name: 'bucket',
-            description:
-              "App's containing bucket. Can either be a name (e.g `extras`) or a URL to a GitHub Repo (e.g `https://github.com/jewlexx/personal-scoop`)",
+            description,
             example: 'extras',
           }),
         ],

diff --git a/services/scoop/scoop-version.service.js b/services/scoop/scoop-version.service.js
@@ -1,7 +1,7 @@
 import Joi from 'joi'
 import { pathParam, queryParam } from '../index.js'
 import { renderVersionBadge } from '../version.js'
-import ScoopBase from './scoop-base.js'
+import { description, ScoopBase } from './scoop-base.js'
 
 const scoopSchema = Joi.object({
   version: Joi.string().required(),
@@ -33,8 +33,7 @@ export default class ScoopVersion extends ScoopBase {
           pathParam({ name: 'app', example: 'ngrok' }),
           queryParam({
             name: 'bucket',
-            description:
-              "App's containing bucket. Can either be a name (e.g `extras`) or a URL to a GitHub Repo (e.g `https://github.com/jewlexx/personal-scoop`)",
+            description,
             example: 'extras',
           }),
         ],