set a default for authType, fix broken tests

badges · Jul 31, 2023 · 80857c5 · 80857c5
1 parent 8ba6ad1
commit 80857c5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/services/github/github-api-provider.js b/services/github/github-api-provider.js
@@ -43,7 +43,7 @@ class GithubApiProvider {
   //   reserve it for the user.
   constructor({
     baseUrl,
-    authType,
+    authType = this.constructor.AUTH_TYPES.NO_AUTH,
     onTokenInvalidated = tokenString => {},
     globalToken,
     reserveFraction = 0.25,

diff --git a/services/github/github-api-provider.spec.js b/services/github/github-api-provider.spec.js
@@ -8,7 +8,11 @@ describe('Github API provider', function () {
 
   let mockStandardToken, mockSearchToken, mockGraphqlToken, provider
   beforeEach(function () {
-    provider = new GithubApiProvider({ baseUrl, reserveFraction })
+    provider = new GithubApiProvider({
+      baseUrl,
+      authType: GithubApiProvider.AUTH_TYPES.TOKEN_POOL,
+      reserveFraction,
+    })
 
     mockStandardToken = { update: sinon.spy(), invalidate: sinon.spy() }
     sinon.stub(provider.standardTokens, 'next').returns(mockStandardToken)

diff --git a/services/github/github-auth-service.spec.js b/services/github/github-auth-service.spec.js
@@ -41,6 +41,7 @@ describe('GithubAuthV3Service', function () {
     )
     const githubApiProvider = new GithubApiProvider({
       baseUrl: 'https://github-api.example.com',
+      authType: GithubApiProvider.AUTH_TYPES.TOKEN_POOL,
       restApiVersion: '2022-11-28',
     })
     const mockToken = { update: sinon.mock(), invalidate: sinon.mock() }