Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't add v prefix to commit hash "version"s #10591

Closed
chris48s opened this issue Oct 8, 2024 Discussed in #10590 · 1 comment · Fixed by #10597
Closed

don't add v prefix to commit hash "version"s #10591

chris48s opened this issue Oct 8, 2024 Discussed in #10590 · 1 comment · Fixed by #10597
Assignees
@jNullj
Labels
core Server, BaseService, GitHub auth, Shared helpers

Comments

@chris48s
Copy link
Member

chris48s commented Oct 8, 2024

Discussed in #10590

Originally posted by ingenarel October 6, 2024
here's what i mean:
i've made a scoop bucket that's aur -git package inspired. the version of a package is the git commit hash
image

now the thing is the version says 1769fa..

but on the readme, i can see a v before it.
image

is there any way to not do that?
@chris48s chris48s added the core Server, BaseService, GitHub auth, Shared helpers label Oct 8, 2024
@MohanKumarAmbati
Copy link
Contributor

Hi @chris48s , how about using a regex to identify if the string is git commit hash and remove v based on that..?

@jNullj jNullj self-assigned this Oct 11, 2024
jNullj added a commit to jNullj/shields-fun-fork that referenced this issue Oct 11, 2024
@jNullj
addv ignore commit hash
5aa272d 
some services might return version as a commit hash like aur.
it makes no sense to prefix v before the commit.

Fixes badges#10591
@jNullj jNullj mentioned this issue Oct 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 12, 2024
@jNullj
remove prefix v for commit hash version (#10597)
f767fab 
* addv ignore commit hash

some services might return version as a commit hash like aur.
it makes no sense to prefix v before the commit.

Fixes #10591

* add addv commit hash tests

add both full commit hash and short commit hash tests to addv.
expected result - no v prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jNullj jNullj

Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove prefix v for commit hash version jNullj/shields-fun-fork
3 participants
@chris48s @jNullj @MohanKumarAmbati