-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move osslifecycle and nycrc into /github #5343
Comments
I know those two badges only support looking for their respective files in github today, but is there any reason that has to be the case? For example I could just easily use Bitbucket and nyc and want the badge. I know we haven't had any asks for those just yet, but perhaps worth considering. |
Hmm.. that's broadly also true of all the other "get a file from a github repo and extract a value" badges. i.e:
Whichever way we look at it, we should treat osslifecycle and nycrc the same as all of those, but maybe there is a case that none of those should be github-specific |
Excellent point! Maybe in a perfect world we'd have a "get a file from (VCS provider) and extract a value" framework/reusable functions or base classes. |
And just to clarify, I don't have any objections to moving these services under the github directory, regardless of what we may or may not do down the line. At this point it's really more about easily knowing where all the service classes are that use the GitHub APIs to do their thing. |
Another relevant consideration here |
As noted in #5234 these two anomolies should be moved into the
/github
dir and URL namespace, like all the other "get a file from a github repo and extract a value" badges. We should set up redirects for compatibility.The text was updated successfully, but these errors were encountered: