Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunsetting Shields custom logos #10347

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Jul 10, 2024

Goes ahead with the decision made in #9476.

In terms of communication, we could pin the content of the blogs in an issue as well.

@PyvesB PyvesB added the core Server, BaseService, GitHub auth, Shared helpers label Jul 10, 2024
Copy link
Contributor

github-actions bot commented Jul 10, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against a6e0af6

@PyvesB PyvesB force-pushed the remove-custom-shields-logos branch 2 times, most recently from be0eff1 to 1280e60 Compare July 10, 2024 13:22
Copy link
Contributor

🚀 Updated review app: https://pr-10347-badges-shields.fly.dev

@PyvesB PyvesB force-pushed the remove-custom-shields-logos branch from 1280e60 to dac6c73 Compare July 10, 2024 13:29
@PyvesB PyvesB force-pushed the remove-custom-shields-logos branch from dac6c73 to 1445833 Compare July 10, 2024 16:57
Copy link
Contributor

🚀 Updated review app: https://pr-10347-badges-shields.fly.dev

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm. I love the smell of deprecation in the morning. Thanks for picking this up.

I've flagged a couple of minor points on the documentation around this, but this is mostly good to go 👍

doc/logos.md Show resolved Hide resolved
@PyvesB PyvesB added this pull request to the merge queue Jul 13, 2024
Merged via the queue into badges:master with commit 1e4c8f5 Jul 13, 2024
23 checks passed
@PyvesB PyvesB deleted the remove-custom-shields-logos branch July 13, 2024 19:20
@PyvesB
Copy link
Member Author

PyvesB commented Jul 13, 2024

Will deploy and repost in an issue tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants